[wip] fix shellcheck errors higher than warnings

[upodroid]

As part of enabling the shell style checks, we need to ensure that all shellcheck warnings have been addressed:

Most of them have been fixed except one:

 REDACTED  C02CW0CDP3YY  ~  Desktop  Git  serving   shellcheck-fixes  7✎  $  shellcheck test/*.sh -S warning

In test/e2e-common.sh line 568:
        for file in $(find -L "${source_dir}" -type f -name "*.yaml"); do
                    ^-- SC2044 (warning): For loops over find output are fragile. Use find -exec or a while read loop.

For more information:
  https://www.shellcheck.net/wiki/SC2044 -- For loops over find output are fr...

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/OWNERS [upodroid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (ea2a6c8) 86.25% compared to head (b49d986) 86.21%.

❗ Current head b49d986 differs from pull request most recent head 55933c0. Consider uploading reports for the commit 55933c0 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13971      +/-   ##
==========================================
- Coverage   86.25%   86.21%   -0.05%     
==========================================
  Files         199      199              
  Lines       14749    14759      +10     
==========================================
+ Hits        12722    12724       +2     
- Misses       1726     1733       +7     
- Partials      301      302       +1     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[dprotaso]

this can't be quoted

• see the errors in the prow job

[upodroid]

Fixed

[knative-prow]

@upodroid: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
istio-latest-no-mesh-tls_serving_main	55933c0	link	true	/test istio-latest-no-mesh-tls
istio-latest-no-mesh_serving_main	55933c0	link	true	/test istio-latest-no-mesh

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dprotaso]

seems like we want some variables to not be quoted so that the args are expanded in some command invocations

[upodroid]

Yeah, it is whack a mole, for example I adjusted the net-istio fetch script to work with the variables being quoted. I'll dig around and make changes

[knative-prow-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dprotaso]

marking as WIP

[upodroid]

Got distracted, will get this ready by the end of the week

[dprotaso]

@upodroid are you still working on this? Otherwise I'll close this and maybe open a good first issue

[upodroid]

I'll work on it after the deprecate kntest PR is merged

[dprotaso]

You should be unblocked now

[dprotaso]

Going to close this out - feel free to re-open when you get a chance to pick up the work again