Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(activator): Don't cancel all probes on one probe failure #14303

Merged
merged 3 commits into from
Sep 12, 2023

Commits on Aug 28, 2023

  1. fix(activator): Don't cancel all probes on one probe failure

    By using errgroup.WithContext, all probes are cancelled on the first
    error returned.  This changes to use an errgroup without a
    context/cancellation.  So all probes are allowed to run to completion
    and one failed probe does not cause all probes to exit.
    
    Ref knative#14200
    arsenetar committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    ac602c1 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. fix(activator): Update tests to include pod IP probe tests

    - Add pod IP probe tests to directly test the pod IP probing behavior
      - Add test for no-probe optimization when all healthy
      - Add test for a pod returning an error to verify it does not block /
        cancel other probes (confirmed test with prior code which fails)
    - Update the fake roundtripper to support the new pod IP probe tests by
      introducing the Delay field to be used to delay the response.  Default
      handling skips the delay if not set.
    - Add comment to errgroup change since this had been correct before and
      was incorrectly changed. (Additionally change to use original form.)
    arsenetar committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    278bfcc View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. refactor(activator): Refactor roundtripper for test

    Update to use a function for the delay to reduce duplicate code.
    arsenetar committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    ba249c9 View commit details
    Browse the repository at this point in the history