Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(activator): Correctly return noop value from probePodIPs based on changes #14347

Merged
merged 2 commits into from
Sep 25, 2023

Commits on Sep 12, 2023

  1. fix(activator): Correct probePodIPs to return correct noop value

    The probePodIPs sometimes (depending on configuration) will return a
    true for noop when in fact there are changes.  This is due to changes to
    the healthy endpoints being possible outside of probing.
    
    - Change the unchanged value to just compare the existing healthy set
      with the new one.
    - Add tests to cover most of the different cases of behavior for the
      probePodIPs function.
    
    NOTE: There is one test case `no changes without probes` that now shows
    different behavior than prior code.  Prior code would return a false for
    noop.  After reviewing the calling code this did not seem to make sense
    for a non-probing non-updating call to update the endpoints (given the
    other non-probe changes are now accounted for).  So this was left as it
    is now with the simple unchanged value logic.
    arsenetar committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    8229a1c View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. fix(tests): Refactor new tests

    - Rename one test case
    - Move both rw and fakeRT inside test function
    arsenetar committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    5a6a187 View commit details
    Browse the repository at this point in the history