Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.12] Bump to fix #14732 #14733

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

dprotaso
Copy link
Member

Part of #14732

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2023
@dprotaso
Copy link
Member Author

/retest

@dprotaso dprotaso mentioned this pull request Dec 18, 2023
14 tasks
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2023
Copy link

knative-prow bot commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (239b73e) 86.00% compared to head (49b2374) 86.02%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.12   #14733      +/-   ##
================================================
+ Coverage         86.00%   86.02%   +0.02%     
================================================
  Files               197      197              
  Lines             14922    14922              
================================================
+ Hits              12833    12836       +3     
+ Misses             1777     1776       -1     
+ Partials            312      310       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member Author

/override "test (v1.28.x, istio-ambient, runtime)"
/override "test (v1.28.x, istio-ambient, api)"

Copy link

knative-prow bot commented Dec 18, 2023

@dprotaso: Overrode contexts on behalf of dprotaso: test (v1.28.x, istio-ambient, api), test (v1.28.x, istio-ambient, runtime)

In response to this:

/override "test (v1.28.x, istio-ambient, runtime)"
/override "test (v1.28.x, istio-ambient, api)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit f1bd929 into knative:release-1.12 Dec 18, 2023
75 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants