Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated] Update net-certmanager nightly #14845

Merged

Conversation

knative-automation
Copy link
Contributor

/assign @knative/serving-writers
/cc @knative/serving-writers

Produced via:

for x in net-certmanager.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-certmanager/latest/$x > ${GITHUB_WORKSPACE}/./third_party/cert-manager-latest/$x
done

Details:

bumping knative.dev/net-certmanager 7397714...7ae5cb7:
  > 7ae5cb7 upgrade to latest dependencies (# 660)
  > 8007522 upgrade to latest dependencies (# 659)

bumping knative.dev/net-certmanager 7397714...7ae5cb7:
  > 7ae5cb7 upgrade to latest dependencies (# 660)
  > 8007522 upgrade to latest dependencies (# 659)

Signed-off-by: Knative Automation <automation@knative.team>
@knative-automation knative-automation force-pushed the update-nightly/net-certmanager branch from 01e2f73 to f37fd26 Compare January 30, 2024 11:05
@knative-prow knative-prow bot requested a review from a team January 30, 2024 11:05
Copy link

knative-prow bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knative-automation
Once this PR has been reviewed and has the lgtm label, please assign retocode for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added area/networking size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6d89c70) 85.84% compared to head (f37fd26) 85.77%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14845      +/-   ##
==========================================
- Coverage   85.84%   85.77%   -0.07%     
==========================================
  Files         198      198              
  Lines       15117    15117              
==========================================
- Hits        12977    12967      -10     
- Misses       1820     1827       +7     
- Partials      320      323       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ReToCode
Copy link
Member

/test https

Copy link

knative-prow bot commented Jan 30, 2024

@knative-automation: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
https_serving_main f37fd26 link false /test https

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knative-prow knative-prow bot merged commit 48a3a52 into knative:main Jan 30, 2024
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants