Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add revision-failure test image #14875

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Add revision-failure test image #14875

merged 2 commits into from
Feb 15, 2024

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Feb 9, 2024

This let's you control which revisions fail on startup by updating a config map with the revision name as the key

eg. kubectl patch configmap revision-failure -p '{"data":{"revision-failure-00001":"1"}}'

This is useful for debugging so thought it would be worth contributing

@knative-prow knative-prow bot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Feb 9, 2024
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 9, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (52b4b09) 85.79% compared to head (94ad068) 85.77%.
Report is 21 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14875      +/-   ##
==========================================
- Coverage   85.79%   85.77%   -0.03%     
==========================================
  Files         198      198              
  Lines       15126    15153      +27     
==========================================
+ Hits        12978    12997      +19     
- Misses       1826     1830       +4     
- Partials      322      326       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member Author

dprotaso commented Feb 9, 2024

finished with error: All cluster resources were brought up, but: only 11 nodes out of 12 have registered; cluster may be unhealthy.\n

/retest

@dprotaso
Copy link
Member Author

dprotaso commented Feb 9, 2024

/retest

@skonto
Copy link
Contributor

skonto commented Feb 13, 2024

Are we planning to re-use it in tests?

ReToCode
ReToCode approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold other than the two nits, LGTM. Feel free to either update or just unhold

/lgtm
/approve

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2024
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2024
@dprotaso
Copy link
Member Author

I'm trying to write some e2e tests to help verify the changes in the PRs I'm reviewing

#14875
#14573

I found this image to be useful and I'll contribute the e2e tests in another PR

I might add some more functionality to this image before merging

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2024
@dprotaso
Copy link
Member Author

/assign @izabelacg

@izabelacg
Copy link
Member

/LGTM

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2024
@izabelacg
Copy link
Member

/approve

@knative-prow Knative Prow
Copy link

knative-prow bot commented Feb 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, izabelacg, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Member Author

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2024
@ReToCode
Copy link
Member

/test istio-latest-no-mesh

@dprotaso
Copy link
Member Author

/retest

@knative-prow knative-prow bot merged commit 8589e0c into knative:main Feb 15, 2024
49 checks passed
@dprotaso dprotaso deleted the revision-failure branch February 15, 2024 19:30
@dprotaso dprotaso mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skonto skonto skonto left review comments

@ReToCode ReToCode ReToCode approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

@mgencur mgencur Awaiting requested review from mgencur

Assignees

@izabelacg izabelacg

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dprotaso @skonto @izabelacg @ReToCode