Add coverage for Route controller failure paths. #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-prow-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
size/L
mattmoor
force-pushed
the
unstable-reactor
branch
from
b67f92a to
584db70
Compare
google-prow-robot
added
size/XL
mattmoor
changed the title
google-prow-robot
removed
the
do-not-merge/work-in-progress
tcnghia
reviewed
Jul 6, 2018
pkg/controller/testing/reactions.go
Outdated
| clientgotesting "k8s.io/client-go/testing" | ||
| ) | ||
|
|
||
| func InduceFailure(verb, resource string) clientgotesting.ReactionFunc { |
There was a problem hiding this comment.
Add some comments of how to use this?
mattmoor
force-pushed
the
unstable-reactor
branch
2 times, most recently
from
49e22ac to
207a31d
Compare
This introduces new functionality to our `TableTest` to enable a `Row` to provide `clientgotesting.ReactionFunc`s to induce failures during API requests through the fake clients. For example:
```go
// Induce a failure creating revisions.
WantErr: true,
WithReactors: []clientgotesting.ReactionFunc{
InduceFailure("create", "revisions"),
},
```
Fixes: knative/serving#1501
mattmoor
force-pushed
the
unstable-reactor
branch
from
207a31d to
0d02089
Compare
|
/lgtm |
|
The following is the coverage report on pkg/. Say
*TestCoverage feature is being tested, do not rely on any info here yet |
|
route.go 98.8% ! |
|
/test pull-knative-serving-unit-tests |
1 similar comment
|
/test pull-knative-serving-unit-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces new functionality to our
TableTestto enable aRowto provideclientgotesting.ReactionFuncs to induce failures during API requests through the fake clients. For example:Fixes: #1501