Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration timeout defaulting #15617

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Nov 15, 2024

Fixes #15616

Proposed Changes

  • As per title. We inject the right context for revision config to be properly updated with the latest values.
  • This affects revision-response-start-timeout-seconds, revision-idle-timeout-seconds, so that when they are equal to the revision-timeout-seconds in the defaults cm, they will not be set to 300 (default) at a revision that has no overrides of those values. Instead they are set to nil at the revision (0 at the QP side). Semantically this is correct, since when the timeouts are equal we don't need both anyway.

Release Note

NONE

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 15, 2024
Copy link

knative-prow bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: skonto
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@skonto skonto requested review from dprotaso and removed request for izabelacg November 15, 2024 11:03
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.55%. Comparing base (ebe9d03) to head (f3c3ee1).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15617      +/-   ##
==========================================
- Coverage   83.55%   83.55%   -0.01%     
==========================================
  Files         219      219              
  Lines       17427    17437      +10     
==========================================
+ Hits        14561    14569       +8     
- Misses       2495     2498       +3     
+ Partials      371      370       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@skonto skonto added this to the v1.17.0 milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

revision-response-start-timeout-seconds is set wrongly
3 participants