Fix --admission-control link #165
Conversation
I think this was intended to be a link.
| @@ -31,8 +31,7 @@ You'll also need to setup: | |||
| kubectl create clusterrolebinding cluster-admin-binding \ | |||
| --clusterrole=cluster-admin --user=${YOUR_KUBE_USER} | |||
| ``` | |||
| 1. Kubernetes cluster must have MutatingAdmissionWebhook specified in the [--admission-control as per]: | |||
| (https://kubernetes.io/docs/admin/extensible-admission-controllers/#enable-external-admission-webhooks) | |||
| 1. Kubernetes cluster must have MutatingAdmissionWebhook specified with [--admission-control](https://kubernetes.io/docs/admin/extensible-admission-controllers/#enable-external-admission-webhooks). | |||
There was a problem hiding this comment.
Can we move this into minikube docs? This isn't even settable on GKE (in this way), and I think that leads to confusion.
There was a problem hiding this comment.
I don't think we have any minikube docs yet. Does this mean we don't need this setting when we use GKE? I think we'd need it with other generic k8s clusters tho?
Maybe @vaikas-google can shed some light, I think he added this initially
There was a problem hiding this comment.
I can confirm that you don't need this when using GKE.
There was a problem hiding this comment.
I started a thread to try and just get minikube fixed :) cc'd @bobcatfish
There was a problem hiding this comment.
@mattmoor how do you feel about merging this fix for the link in the meantime (it's broken right now) or would you rather:
- leave it for now
- delete this line entirely for now
?
|
I think this is superseded by #167 which explains how to accomplish this for minikube clusters (it's not needed for GKE) |
|
Closing this but feel free to reopen if you think it's warranted @bobcatfish! |
np, thanks @grantr ! |
🤖 Triggering CI on branch 'release-next' after synching to upstream/master
I think this was intended to be a link.