Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Release Mode and Manual Mode to Service #2277

Merged
merged 10 commits into from
Oct 26, 2018
Merged

Add Release Mode and Manual Mode to Service #2277

merged 10 commits into from
Oct 26, 2018

Conversation

dgerd
Copy link

@dgerd dgerd commented Oct 22, 2018

Fixes #1865

Proposed Changes

  • Creates two new Service Types: Release and Manual as described in issue
  • Adds Deprecation comment to Pinned Type (to be removed in future API release)

@dgerd
Copy link
Author

dgerd commented Oct 22, 2018

This change still needs:

  • Additional unit test coverage (especially in pkg/reconciler/v1alpha1/service/service_test.go)
  • Conformance test coverage

As release mode creates multiple named routes, this change makes #2276 more likely to be hit.

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2018
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 22, 2018
knative-prow-robot
knative-prow-robot reviewed Oct 22, 2018
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgerd: 6 warnings.

In response to this:

Fixes #1865

Proposed Changes

  • Creates two new Service Types: Release and Manual as described in issue
  • Adds Deprecation comment to Pinned Type (to be removed in future API release)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/reconciler/v1alpha1/service/resources/route.go Outdated Show resolved Hide resolved
pkg/apis/serving/v1alpha1/service_validation.go Show resolved Hide resolved
pkg/apis/serving/v1alpha1/service_validation.go Show resolved Hide resolved
pkg/apis/serving/v1alpha1/service_types.go Show resolved Hide resolved
pkg/apis/serving/v1alpha1/service_types.go Show resolved Hide resolved
pkg/reconciler/v1alpha1/service/resources/configuration.go Outdated Show resolved Hide resolved
@dgerd
Copy link
Author

dgerd commented Oct 23, 2018

/test pull-knative-serving-unit-tests

mattmoor
mattmoor reviewed Oct 23, 2018
View reviewed changes
pkg/apis/serving/v1alpha1/service_types.go Outdated Show resolved Hide resolved
pkg/apis/serving/v1alpha1/service_types.go Outdated Show resolved Hide resolved
pkg/apis/serving/v1alpha1/service_types.go Outdated Show resolved Hide resolved
pkg/apis/serving/v1alpha1/service_types.go Outdated Show resolved Hide resolved
pkg/apis/serving/v1alpha1/service_types.go Outdated Show resolved Hide resolved
pkg/apis/serving/v1alpha1/service_validation.go Outdated Show resolved Hide resolved
pkg/reconciler/v1alpha1/service/resources/configuration.go Outdated Show resolved Hide resolved
pkg/reconciler/v1alpha1/service/resources/route.go Outdated Show resolved Hide resolved
pkg/reconciler/v1alpha1/service/service.go Outdated Show resolved Hide resolved
pkg/reconciler/v1alpha1/service/service.go Outdated Show resolved Hide resolved
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 24, 2018
mattmoor
mattmoor reviewed Oct 24, 2018
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests as sketched in TODOs look good to me, comments inline.

test/service.go Outdated Show resolved Hide resolved
test/service.go Outdated Show resolved Hide resolved
test/service.go Outdated Show resolved Hide resolved
test/crd.go Outdated Show resolved Hide resolved
test/conformance/service_test.go Outdated Show resolved Hide resolved
test/conformance/service_test.go Outdated Show resolved Hide resolved
test/conformance/service_test.go Outdated Show resolved Hide resolved
test/conformance/service_test.go Outdated Show resolved Hide resolved
test/conformance/service_test.go Outdated Show resolved Hide resolved
Dan Gerdesmeier added 7 commits October 25, 2018 19:51
Add Release Mode and Manual Mode to Service
dcbe8b8
Fix golint errors
12cd4c7
Add additional unit tests for release and manual service types
31c9994
Address comments
471a201
Passing conformance tests
3a53eae 
Still some additional checks to add
Update conformance tests
c404b4a
Test fixes and behavior changes
6aefc5e 
* Update validation for revision list
* Move manual test into BlueGreen
* Update status behavior for manual mode
* Update Release conformance tests
@dgerd dgerd changed the title [WIP] Add Release Mode and Manual Mode to Service Add Release Mode and Manual Mode to Service Oct 25, 2018
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 25, 2018
@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 25, 2018
mattmoor
mattmoor reviewed Oct 25, 2018
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

I know you are poking at this a little still, but this LGTM. The tests are awesome.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2018
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2018
@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2018
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/v1alpha1/service/service.go 92.5% 91.0% -1.5

@dgerd
Copy link
Author

dgerd commented Oct 26, 2018

Okay so I am done poking at this. I updated the way manual status is being set to be safer when fields are added. The conformance tests need to be ran with a ingressgateway replicas set to 1 to avoid being flaky, but I have validated that they work consistently otherwise.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2018
mattmoor
mattmoor reviewed Oct 26, 2018
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
🎉 thanks @dgerd this is awesome!

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgerd, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mattmoor
Copy link
Member

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2018
@knative-prow-robot knative-prow-robot merged commit f53961d into knative:master Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@mattmoor mattmoor mattmoor left review comments

@tcnghia tcnghia Awaiting requested review from tcnghia

Assignees

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dgerd @knative-metrics-robot @knative-prow-robot @mattmoor