Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable websocket upgrade in Istio VirtualService. #2910

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Enable websocket upgrade in Istio VirtualService. #2910

merged 1 commit into from
Jan 15, 2019

Conversation

tcnghia
Copy link
Contributor

@tcnghia tcnghia commented Jan 14, 2019

Fixes #

Proposed Changes

  • Enable websocket upgrade by default in Istio VirtualServices.

Release Note

NONE

@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 14, 2019
knative-prow-robot
knative-prow-robot reviewed Jan 14, 2019
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tcnghia: 0 warnings.

In response to this:

Fixes #

Proposed Changes

  • Enable websocket upgrade by default in Istio VirtualServices.

Release Note

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tcnghia
Copy link
Contributor Author

tcnghia commented Jan 15, 2019

/test pull-knative-serving-integration-tests

1 similar comment
@tcnghia
Copy link
Contributor Author

tcnghia commented Jan 15, 2019

/test pull-knative-serving-integration-tests

@markusthoemmes
Copy link
Contributor

Good old TestRunLatest flake

/test pull-knative-serving-integration-tests

@markusthoemmes
Copy link
Contributor

Do we need an E2E test to assert something here? I.e. are we expecting Websocket connections to work end-to-end now and what didn't work before?

@tcnghia
Copy link
Contributor Author

tcnghia commented Jan 15, 2019

@markusthoemmes Yes, that is a good idea. I will follow up with an integration test.

@mchmarny mchmarny self-requested a review January 15, 2019 17:30
@mchmarny
Copy link
Member

/lgtm
/approved

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2019
mchmarny
mchmarny approved these changes Jan 15, 2019
View reviewed changes
Copy link
Member

@mchmarny mchmarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mchmarny, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tcnghia
Copy link
Contributor Author

tcnghia commented Jan 15, 2019

TestScaleTo10 is flaky.

/test pull-knative-serving-integration-tests

@knative-prow-robot knative-prow-robot merged commit 8ed03fb into knative:master Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@mchmarny mchmarny mchmarny approved these changes

@ZhiminXiang ZhiminXiang Awaiting requested review from ZhiminXiang

@markusthoemmes markusthoemmes Awaiting requested review from markusthoemmes

@mdemirhan mdemirhan Awaiting requested review from mdemirhan

Assignees

@mchmarny mchmarny

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tcnghia @markusthoemmes @mchmarny @knative-prow-robot