Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently use ObservedGeneration across our types and controllers. #3076

Merged
merged 2 commits into from
Feb 12, 2019
Merged

Consistently use ObservedGeneration across our types and controllers. #3076

merged 2 commits into from
Feb 12, 2019

Conversation

mattmoor
Copy link
Member

@mattmoor mattmoor commented Feb 3, 2019

WIP until #3075 merges

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2019
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 3, 2019
@vagababov
Copy link
Contributor

It seems there are two changes here.
One belongs here and the other to the cleanup of the tests for wait for controller to exit?

@mattmoor
Copy link
Member Author

mattmoor commented Feb 3, 2019 •
edited
Loading

@vagababov Yeah, see note in PR ;-)

Github lacks DIFFBASE :-/

vagababov
vagababov approved these changes Feb 3, 2019
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2019
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 4, 2019
@mattmoor mattmoor changed the title [WIP] Consistently use ObservedGeneration across our types and controllers. Consistently use ObservedGeneration across our types and controllers. Feb 4, 2019
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2019
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2019
vagababov
vagababov reviewed Feb 4, 2019
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/v1alpha1/autoscaling/hpa/hpa.go 62.7% 63.2% 0.5
pkg/reconciler/v1alpha1/autoscaling/kpa/kpa.go 86.7% 86.8% 0.1
pkg/reconciler/v1alpha1/clusteringress/clusteringress.go 78.4% 78.6% 0.2
pkg/reconciler/v1alpha1/revision/revision.go 90.8% 90.9% 0.1
pkg/reconciler/v1alpha1/route/route.go 92.1% 92.2% 0.1

@vagababov
Copy link
Contributor

need moaaar tests 🌮

@mattmoor
Copy link
Member Author

mattmoor commented Feb 4, 2019

/test pull-knative-serving-unit-tests

@mattmoor
Copy link
Member Author

mattmoor commented Feb 4, 2019

I opened issues for the two controllers under 80%, but that presubmit doesn't block submits.

dgerd
dgerd reviewed Feb 5, 2019
View reviewed changes
pkg/reconciler/v1alpha1/revision/revision.go
@@ -400,6 +400,7 @@ func (c *Reconciler) reconcile(ctx context.Context, rev *v1alpha1.Revision) erro
}
}

rev.Status.ObservedGeneration = rev.Generation
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So observed generation for revision exists but we as not being utilized before? Can you add a test as part of this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it to all of our e2e tests, since the fakes don't deal with metadata.generation setting :(

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mattmoor
Copy link
Member Author

mattmoor commented Feb 6, 2019

/test pull-knative-serving-unit-tests

vagababov
vagababov reviewed Feb 12, 2019
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2019
@mattmoor
Copy link
Member Author

/test pull-knative-serving-unit-tests

1 similar comment
@mattmoor
Copy link
Member Author

/test pull-knative-serving-unit-tests

@knative-prow-robot knative-prow-robot merged commit aa6e255 into knative:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgerd dgerd dgerd left review comments

@vagababov vagababov vagababov approved these changes

@jonjohnsonjr jonjohnsonjr Awaiting requested review from jonjohnsonjr

@josephburnett josephburnett Awaiting requested review from josephburnett

@lichuqiang lichuqiang Awaiting requested review from lichuqiang

@markusthoemmes markusthoemmes Awaiting requested review from markusthoemmes

@mdemirhan mdemirhan Awaiting requested review from mdemirhan

@tcnghia tcnghia Awaiting requested review from tcnghia

Assignees

@vagababov vagababov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mattmoor @vagababov @knative-metrics-robot @knative-prow-robot @dgerd