Surface events for all reconciliation failures. #3462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
area/API
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
knative-prow-robot
requested review from
dgerd,
markusthoemmes,
mdemirhan and
tcnghia
|
/retest |
vagababov
reviewed
Mar 20, 2019
Today errors during reconciliation are generally just logged which isn't particularly friendly for users who might not want to dig through our controller logs. This changes our boilerplate to surface any errors we encounter during a call to `Reconcile()`. Fixes: knative#2941
All of the other reconcilers do this today.
mattmoor
force-pushed
the
events-on-errors
branch
from
c3b2aba
to
68f108b
Compare
|
rebased |
|
The following is the coverage report on pkg/.
|
|
/retest |
1 similar comment
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today errors during reconciliation are generally just logged which isn't particularly friendly for users who might not want to dig through our controller logs.
This changes our boilerplate to surface any errors we encounter during a call to
Reconcile().Fixes: #2941