Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only add KPA label to a K8S service of a revision if KPA is used #3498

Merged
merged 6 commits into from
Mar 25, 2019
Merged

Only add KPA label to a K8S service of a revision if KPA is used #3498

merged 6 commits into from
Mar 25, 2019

Conversation

yanweiguo
Copy link
Contributor

@yanweiguo yanweiguo commented Mar 22, 2019 •
edited
Loading

Fixes #2606

Proposed Changes

  • Only add label autoscaling.knative.dev/kpa to a K8S service of a Revision if KPA is used for this Revision.

Release Note

None

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/API API objects and controllers labels Mar 22, 2019
knative-prow-robot
knative-prow-robot reviewed Mar 22, 2019
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yanweiguo: 0 warnings.

In response to this:

Fixes #2606

Proposed Changes

  • Add annotation autoscaling.knative.dev/class: kpa.autoscaling.knative.dev to a Revision if this annotation is not present in RevisionTemplate. In this case KPA is used by default.
  • Only add label autoscaling.knative.dev/kpa to a K8S service of a Revision if KPA is used for this Revision.

Release Note

Annotation `autoscaling.knative.dev/class: kpa.autoscaling.knative.dev` is added to Revisions if this annotation is not present in `RevisionTemplate`.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yanweiguo yanweiguo changed the title Debug pa Only add KPA label to a K8S service of a revision if KPA is used Mar 22, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/v1alpha1/configuration/resources/revision.go 94.7% 95.2% 0.5

vagababov
vagababov reviewed Mar 22, 2019
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good.
Thanks.

pkg/reconciler/v1alpha1/configuration/resources/revision.go Outdated Show resolved Hide resolved
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 22, 2019
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 22, 2019
vagababov
vagababov reviewed Mar 22, 2019
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2019
@vagababov
Copy link
Contributor

Probably you want to change "fixes" part, since this is partial fix.

@yanweiguo
Copy link
Contributor Author

Probably you want to change "fixes" part, since this is partial fix.

It should fix the issue with the change in service.go only.

markusthoemmes
markusthoemmes approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/hold

Hold in case you want to fix the seemingly unwanted diff.

pkg/reconciler/v1alpha1/configuration/resources/revision_test.go Show resolved Hide resolved
@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2019
@yanweiguo
Copy link
Contributor Author

/test pull-knative-serving-upgrade-tests
/test pull-knative-serving-integration-tests

@yanweiguo
Copy link
Contributor Author

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2019
@yanweiguo
Copy link
Contributor Author

/test pull-knative-serving-upgrade-tests

3 similar comments
@yanweiguo
Copy link
Contributor Author

/test pull-knative-serving-upgrade-tests

@yanweiguo
Copy link
Contributor Author

/test pull-knative-serving-upgrade-tests

@yanweiguo
Copy link
Contributor Author

/test pull-knative-serving-upgrade-tests

@markusthoemmes
Copy link
Contributor

/assign @vagababov

For reconciler approval.

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, vagababov, yanweiguo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2019
@yanweiguo
Copy link
Contributor Author

/test pull-knative-serving-upgrade-tests

3 similar comments
@yanweiguo
Copy link
Contributor Author

/test pull-knative-serving-upgrade-tests

@markusthoemmes
Copy link
Contributor

/test pull-knative-serving-upgrade-tests

@markusthoemmes
Copy link
Contributor

/test pull-knative-serving-upgrade-tests

@markusthoemmes
Copy link
Contributor

/test pull-knative-serving-upgrade-tests

We'll get there. Trust me!

@knative-prow-robot knative-prow-robot merged commit 17b9066 into knative:master Mar 25, 2019
@yanweiguo yanweiguo deleted the debug_pa branch July 16, 2019 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@markusthoemmes markusthoemmes markusthoemmes approved these changes

@vagababov vagababov vagababov approved these changes

@mattmoor mattmoor Awaiting requested review from mattmoor

@dprotaso dprotaso Awaiting requested review from dprotaso

@jonjohnsonjr jonjohnsonjr Awaiting requested review from jonjohnsonjr

Assignees

@vagababov vagababov

@markusthoemmes markusthoemmes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yanweiguo @knative-metrics-robot @vagababov @markusthoemmes @knative-prow-robot