Send request metrics from queue proxy #3596
Conversation
knative-prow-robot
added
the
do-not-merge/work-in-progress
knative-prow-robot
added
area/API
There was a problem hiding this comment.
@yanweiguo: 0 warnings.
In response to this:
Add support to send request metrics from the queue proxy. This functionality already exists in Istio mesh and the reason for the duplication here is to move towards eliminating our dependency on Istio's mesh functionality.
/lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow-robot
added
size/XXL
yanweiguo
changed the title
knative-prow-robot
removed
the
do-not-merge/work-in-progress
pkg/reconciler/v1alpha1/clusteringress/resources/virtual_service.go
Outdated
Show resolved
Hide resolved
| @@ -274,7 +285,7 @@ func main() { | |||
|
|
|||
| timeoutHandler := queue.TimeToFirstByteTimeoutHandler(http.HandlerFunc(handler(reqChan, breaker, httpProxy, h2cProxy)), | |||
| time.Duration(revisionTimeoutSeconds)*time.Second, "request timeout") | |||
| composedHandler := pushRequestLogHandler(timeoutHandler) | |||
| composedHandler := pushRequestMetricHandler(pushRequestLogHandler(timeoutHandler)) | |||
There was a problem hiding this comment.
Did you mean to replace the log handler?
There was a problem hiding this comment.
No. Hmm, what I did is adding a handler layer to the log handler, isn't it?
|
minor comments. Mostly about documentation. |
|
/test pull-knative-serving-upgrade-tests |
2 similar comments
|
/test pull-knative-serving-upgrade-tests |
|
/test pull-knative-serving-upgrade-tests |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdemirhan, yanweiguo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
/test pull-knative-serving-integration-tests |
2 similar comments
|
/test pull-knative-serving-integration-tests |
|
/test pull-knative-serving-integration-tests |
|
/lgtm |
|
/test pull-knative-serving-integration-tests |
|
Fixed the cause which breaks integration tests: SERVING_SERVICE can be empty. |
|
The following is the coverage report on pkg/.
|
|
/lgtm |
Add support to send request metrics from the queue proxy. This functionality already exists in Istio mesh and the reason for the duplication here is to move towards eliminating our dependency on Istio's mesh functionality.
/lint