Attempt to fix our probes with mTLS enabled. #4017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we check for the kubelet's user-agent to attempt to distinguish between proper requests and probes, however, with Istio mTLS enabled they rewrite probes, but they do not spoof the Kubelet's User-Agent. This leads to all manner of failure modes (see linked issue for one, another is likely that the probe traffic will prevent scaling to zero). To combat this, in the places we currently key off of the User-Agent we will now be sensitive to a header, which we will explicitly pass in our Activator probes, and rewrite user probes to provide. Fixes: knative#3751
knative-prow-robot
added
the
do-not-merge/work-in-progress
knative-prow-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
mattmoor
changed the title
knative-prow-robot
removed
the
do-not-merge/work-in-progress
|
The following is the coverage report on pkg/.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we check for the kubelet's user-agent to attempt to distinguish
between proper requests and probes, however, with Istio mTLS enabled they
rewrite probes, but they do not spoof the Kubelet's User-Agent. This leads
to all manner of failure modes (see linked issue for one, another is likely
that the probe traffic will prevent scaling to zero).
To combat this, in the places we currently key off of the User-Agent we will
now be sensitive to a header, which we will explicitly pass in our Activator
probes, and rewrite user probes to provide.
Fixes: #3751
This is WIP mainly because I'd like some form of confirmation that it works before we let it in.