Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply various fixes pointed out by staticcheck. #4242

Merged
merged 12 commits into from
Jun 4, 2019
Merged

Apply various fixes pointed out by staticcheck. #4242

merged 12 commits into from
Jun 4, 2019

Commits on Jun 4, 2019

  1. Transform string(buf.Bytes()) to buf.String().

    @markusthoemmes
    markusthoemmes committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    32aea00 View commit details
    Browse the repository at this point in the history

  2. Remove a bunch of unused code.

    @markusthoemmes
    markusthoemmes committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    6723f4e View commit details
    Browse the repository at this point in the history

  3. Fix error capitalization.

    @markusthoemmes
    markusthoemmes committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    593eed4 View commit details
    Browse the repository at this point in the history

  4. Fix issue with error overlapping.

    @markusthoemmes
    markusthoemmes committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    2f72a80 View commit details
    Browse the repository at this point in the history

  5. Fix deprecated usage of Apps without version.

    @markusthoemmes
    markusthoemmes committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    46e270b View commit details
    Browse the repository at this point in the history

  6. Fix file permission resolution.

    @markusthoemmes
    markusthoemmes committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    152b34a View commit details
    Browse the repository at this point in the history

  7. Fix comparison to boolean.

    @markusthoemmes
    markusthoemmes committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    c75e265 View commit details
    Browse the repository at this point in the history

  8. Fix issue with variable never being used.

    @markusthoemmes
    markusthoemmes committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    985a58b View commit details
    Browse the repository at this point in the history

  9. Remove unused conditionsets.

    @markusthoemmes
    markusthoemmes committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    15e3f69 View commit details
    Browse the repository at this point in the history

  10. Fix error checks after fixing capitalization.

    @markusthoemmes
    markusthoemmes committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    fd269a7 View commit details
    Browse the repository at this point in the history

  11. Remove unused values in performance tests.

    @markusthoemmes
    markusthoemmes committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    7525af0 View commit details
    Browse the repository at this point in the history

  12. Remove some more unused code.

    @markusthoemmes
    markusthoemmes committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    1d83373 View commit details
    Browse the repository at this point in the history