Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also build :everything during presubmit tests #528

Merged
merged 1 commit into from
Mar 30, 2018
Merged

Also build :everything during presubmit tests #528

merged 1 commit into from
Mar 30, 2018

Conversation

adrcunha
Copy link
Contributor

No description provided.

@google-prow-robot google-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 29, 2018
@adrcunha adrcunha requested a review from mattmoor March 29, 2018 16:14
@adrcunha
Copy link
Contributor Author

Tests won't pass until #527 is merged.

@mattmoor
Copy link
Member

/lgtm

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2018
@adrcunha
Copy link
Contributor Author

/retest

@steuhs
Copy link
Contributor

steuhs commented Mar 29, 2018

/approve

@adrcunha
Copy link
Contributor Author

/retest

@krzyzacy
Copy link

/test all

@krzyzacy
Copy link

{"client":"github","component":"tide","level":"info","msg":"Merge(elafros, elafros, 528, {  12d0e7aca66e91806379dac78f0510108dbbc0c1 squash})","time":"2018-03-29T21:04:13Z"}
{"base-sha":"abfe1677d1e3adf53016c2955417c4fbf4bf161c","branch":"master","component":"tide","controller":"sync","error":"Waiting on code owner review from bobcatfish, srinivashegde86, and/or steuhs.","level":"error","msg":"Merge failed: PR is unmergable. How did it pass tests?!","org":"elafros","pr":528,"repo":"elafros","sha":"12d0e7aca66e91806379dac78f0510108dbbc0c1","time":"2018-03-29T21:04:14Z"}
{"action":"MERGE","base-sha":"abfe1677d1e3adf53016c2955417c4fbf4bf161c","branch":"master","component":"tide","controller":"sync","level":"info","msg":"Subpool synced.","org":"elafros","repo":"elafros","targets":[528],"time":"2018-03-29T21:04:14Z"}

looks like this still happens?
cc @cjwagner

@krzyzacy
Copy link

ah, it's waiting for the review context to become green

@knative knative deleted a comment from google-prow-robot Mar 29, 2018
@srinivashegde86
Copy link
Contributor

/approve

@google-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, mattmoor, srinivashegde86, steuhs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • test/OWNERS [adrcunha,mattmoor,srinivashegde86,steuhs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@krzyzacy
Copy link

krzyzacy commented Mar 29, 2018

{"base-sha":"5ef09e17d72d5783adc0f4fd0869e93df33974b4","batch-passing":null,"batch-pending":null,"branch":"master","component":"tide","controller":"sync","level":"info","msg":"Subpool accumulated.","org":"elafros","prs-missing":[528],"prs-passing":[536,485],"prs-pending":null,"repo":"elafros","time":"2018-03-29T23:12:20Z"}

why 528 is missing 😕

@adrcunha adrcunha merged commit 37133a2 into knative:master Mar 30, 2018
@adrcunha adrcunha deleted the buildeverything branch March 30, 2018 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants