Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the POD_IP downward API to the activator. #5693

Closed
wants to merge 2 commits into from
Closed

Add the POD_IP downward API to the activator. #5693

wants to merge 2 commits into from

Conversation

vagababov
Copy link
Contributor

Activator will need to know its address to implement slicing.

Part of #5692.

/assign mattmoor

@vagababov
Add the POD_IP downward API to the activator.
8f8897e 
Activator will need to know its address to implement slicing.

Part of knative#5692.

/assign mattmoor
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 26, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 26, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vagababov
To complete the pull request process, please assign mattmoor
You can assign the PR to them by writing /assign @mattmoor in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vagababov vagababov mentioned this pull request Sep 27, 2019
Merged
@markusthoemmes
Copy link
Contributor

Let's... just move forward with #5696? This is a bit out of context 😂

@vagababov
Copy link
Contributor Author

/close

@knative-prow-robot
Copy link
Contributor

@vagababov: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vagababov vagababov deleted the 20190926-provide-pod-ip branch October 11, 2019 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor-sockpuppet mattmoor-sockpuppet mattmoor-sockpuppet left review comments

@mdemirhan mdemirhan Awaiting requested review from mdemirhan

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@mattmoor mattmoor

Labels
cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vagababov @knative-prow-robot @markusthoemmes @mattmoor-sockpuppet @mattmoor @googlebot