Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This change implements best of two load balanciung algorithm. #5710

Merged
merged 4 commits into from
Sep 30, 2019

Conversation

vagababov
Copy link
Contributor

This is the next step of the steps outlined in #5692.
This change is a drop-in replacement of the current iterative algorithm with the
power of two choices algorithm.

/assign @markusthoemmes mattmoor

/lint

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 27, 2019
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/networking labels Sep 27, 2019
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagababov: 0 warnings.

In response to this:

This is the next step of the steps outlined in #5692.
This change is a drop-in replacement of the current iterative algorithm with the
power of two choices algorithm.

/assign @markusthoemmes mattmoor

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2019
This is the next step of the steps outlined in knative#5692.
This change is a drop in replacement of the current iterative algorithm with the
power of two choices algorithm.

/assign @markusthoemmes mattmoor
pkg/activator/net/throttler.go Outdated Show resolved Hide resolved
pkg/activator/net/throttler.go Outdated Show resolved Hide resolved
pkg/activator/net/throttler.go Outdated Show resolved Hide resolved
pkg/activator/net/throttler_test.go Show resolved Hide resolved
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/activator/net/throttler.go 90.4% 91.7% 1.3

@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-integration-tests pull-knative-serving-integration-tests
pull-knative-serving-integration-tests
2/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-integration-tests:

test/conformance/api/v1alpha1.TestContainerExitingMsg
test/conformance/api/v1alpha1.TestContainerExitingMsg/http

@vagababov
Copy link
Contributor Author

/retest

Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 211b126 into knative:master Sep 30, 2019
@vagababov vagababov deleted the 20190927-best-of-two branch October 11, 2019 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants