remove pointers from types, add webhook validation for service #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-prow-robot
added
approved
|
/assign @evankanderson |
grantr
reviewed
Apr 4, 2018
| ) | ||
|
|
||
| // +genclient | ||
| // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object | ||
|
|
||
| // Service | ||
| type Service struct { | ||
| metav1.TypeMeta `jsonL",inline"` | ||
| metav1.ObjectMeta `json:"metadata,omitempty"` | ||
| metav1.TypeMeta `json",inline"` |
| version: v1alpha1 | ||
| names: | ||
| kind: Service | ||
| plural: services |
There was a problem hiding this comment.
How does this affect kubectl get services? Does it override the core Service resource?
There was a problem hiding this comment.
It doesn't. You have to use the full name for the ela service:
$ kubectl get services
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
git-webhook-00001-autoscaler NodePort 10.11.247.70 <none> 8080:30112/TCP 13d
git-webhook-00001-service NodePort 10.11.240.64 <none> 80:30278/TCP 13d
git-webhook-service ClusterIP 10.11.251.209 <none> 80/TCP 13d
kubernetes ClusterIP 10.11.240.1 <none> 443/TCP 33d
vaikas@vaikas-linux3:~$ kubectl get services.elafros.dev
No resources found.
|
Thanks, PTAL :) |
evankanderson
approved these changes
Apr 5, 2018
| t.Errorf("Expected success, but failed with: %s", err) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
TestRunLatestWithMissingConfiguration?
|
Thanks, PTAL. test added. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson, grantr, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
markusthoemmes
referenced
this pull request
in openshift/knative-serving
Apr 3, 2019
* remove pointers from types, add webhook validation for service * add service.yaml file so the CRD is created * remove errorneous go_library * fix typo * add a test for validating Service with missing RunLatest.Configuration fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #412
Proposed Changes