Remove constructor interface #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'd like to move command flags into the cmd package so controller code isn't aware of flag parsing, which means constructor signatures need to be updated to allow flag values to be passed in. This requires removing the Constructor interface to allow constructor signatures to vary depending on which flags are relevant to each controller. The original idea was that a constructor interface was useful because we'd be adding lots of controllers, but it turned out adding a controller is a rare occurrence.
go vet says this shadows the outer err, which is practically not an issue but we'd like go vet to be green.
google-prow-robot
added
the
size/S
mattmoor
approved these changes
Apr 13, 2018
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantr, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
the
approved
|
/retest |
|
LGTM |
johnugeorge
approved these changes
Apr 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the suggestion from #635 (review). @johnugeorge this should unblock #635.
Proposed Changes
We'd like to move command flags into the cmd package so controller code isn't aware of flag parsing, which means constructor signatures need to be updated to allow flag values to be passed in. This requires removing the Constructor interface to allow constructor signatures to vary depending on which flags are relevant to each controller.
The original idea was that a constructor interface was useful because we'd be adding lots of controllers, but it turned out adding a controller is a rare occurrence.
I also slipped in a variable rename to avoid a go vet warning about shadowed
err. This is in a separate commit.Release Note