Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the issue with overcounting for request counts as well #7109

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Fix the issue with overcounting for request counts as well #7109

merged 1 commit into from
Mar 3, 2020

Conversation

vagababov
Copy link
Contributor

Upon reflection, though less important, I think we should correct number of requests
the same way we do for the concurrent requests, since that requests has already been counted.

For simplification also make all the maps float64, I think the number of casts reduces this way.

/assign mattmoor @markusthoemmes

@vagababov
Fix the issue with overcounting for request counts as well
d366c16 
Upon reflection, though less important, I think we should correct number of requests
the same way we do for the concurrent requests, since _that_ requests has already been counted.

For simplification also make all the maps float64, I think the number of casts reduces this way.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 2, 2020
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/autoscale area/networking approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 2, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/activator/handler/concurrency_reporter.go 87.2% 87.8% 0.6

markusthoemmes
markusthoemmes approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit fcfce72 into knative:master Mar 3, 2020
@vagababov vagababov deleted the 20200302-more-conc-reporter-fixes branch June 23, 2020 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusthoemmes markusthoemmes markusthoemmes approved these changes

@mdemirhan mdemirhan Awaiting requested review from mdemirhan

Assignees

@markusthoemmes markusthoemmes

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/autoscale area/networking cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vagababov @knative-metrics-robot @knative-prow-robot @markusthoemmes @mattmoor @googlebot