Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to v1 types as the storage version #7204

Merged
merged 1 commit into from
Mar 12, 2020
Merged

switch to v1 types as the storage version #7204

merged 1 commit into from
Mar 12, 2020

Conversation

dprotaso
Copy link
Member

Contributes to #6726

Will close off that issue once migration docs are written

Proposed Changes

  • Changes the storage version of Service, Route, Revision, Configuration to v1

Release Note

Changes the storage version of Service, Route, Revision, Configuration to v1

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 10, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 10, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2020
@dprotaso
Copy link
Member Author

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2020
@mattmoor
Copy link
Member

Not sure why this is blocked on migration docs. Feels like we should block removing v1alpha1/v1beta1 on that?

@mattmoor
Copy link
Member

I think I misread: the issue will close then, you are /hold for reasons unknown :)

@dprotaso
Copy link
Member Author

yeah - my /hold was because I want to re-run the tests a few times

@dprotaso
Copy link
Member Author

/retest

@dprotaso
Copy link
Member Author

/retest pull-knative-serving-integration-tests

@dprotaso
Copy link
Member Author

/test pull-knative-serving-integration-tests

1 similar comment
@dprotaso
Copy link
Member Author

/test pull-knative-serving-integration-tests

@dprotaso
Copy link
Member Author

dprotaso commented Mar 10, 2020 via email

@dprotaso
Copy link
Member Author

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2020
@tanzeeb
Copy link
Contributor

tanzeeb commented Mar 12, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2020
@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-integration-tests pull-knative-serving-integration-tests
pull-knative-serving-integration-tests		 2/3

Automatically retrying due to test flakiness...
/test pull-knative-serving-integration-tests

@knative-prow-robot knative-prow-robot merged commit 8478295 into knative:master Mar 12, 2020
@dprotaso dprotaso deleted the storage-v1 branch March 31, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor Awaiting requested review from mattmoor

@tcnghia tcnghia Awaiting requested review from tcnghia

Assignees

@tanzeeb tanzeeb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dprotaso @knative-prow-robot @mattmoor @tanzeeb @knative-test-reporter-robot @googlebot