Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network config sanitization #7395

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Network config sanitization #7395

merged 1 commit into from
Mar 27, 2020

Conversation

vagababov
Copy link
Contributor

  1. Use defaultConfig object to remove spread out defaulting
  2. Update tests to use it.
  3. Verify EXAMPLE stanza matches defaults.
  4. remove redundancy in test declarations

/assign @tcnghia

/lint

@vagababov
Network config sanitization
ce6b55d 
1. Use defaultConfig object to remove spread out defaulting
2. Update tests to use it.
3. Verify EXAMPLE stanza matches defaults.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Mar 26, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/API API objects and controllers area/networking labels Mar 26, 2020
knative-prow-robot
knative-prow-robot reviewed Mar 26, 2020
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vagababov: 0 warnings.

In response to this:

  1. Use defaultConfig object to remove spread out defaulting
  2. Update tests to use it.
  3. Verify EXAMPLE stanza matches defaults.
  4. remove redundancy in test declarations

/assign @tcnghia

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vagababov
Copy link
Contributor Author

/assign @dprotaso mattmoor
for the 3 lines in default-config.go

@vagababov
Copy link
Contributor Author

Don't want to cut a PR for those

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/config/defaults.go 97.1% 97.2% 0.1
pkg/network/network.go 89.0% 89.7% 0.7

@vagababov
Copy link
Contributor Author

Also steps toward #3492.

mattmoor
mattmoor reviewed Mar 26, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2020
@mattmoor
Copy link
Member

/approve
/retest

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2020
@vagababov
Copy link
Contributor Author

/retest

@tcnghia
Copy link
Contributor

tcnghia commented Mar 26, 2020

/lgtm

@vagababov
Copy link
Contributor Author

(ノಠ益ಠ)ノ彡┻━┻

@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-autotls-tests pull-knative-serving-autotls-tests
pull-knative-serving-autotls-tests		 2/3
pull-knative-serving-integration-tests pull-knative-serving-integration-tests 1/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-integration-tests:

test/e2e.TestServiceToServiceCall

@vagababov
Copy link
Contributor Author

/retest

@knative-prow-robot knative-prow-robot merged commit fb10be7 into knative:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@mattmoor mattmoor mattmoor left review comments

@tcnghia tcnghia Awaiting requested review from tcnghia

@yanweiguo yanweiguo Awaiting requested review from yanweiguo

Assignees

@dprotaso dprotaso

@tcnghia tcnghia

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/networking cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@vagababov @knative-metrics-robot @mattmoor @knative-prow-robot @tcnghia @knative-test-reporter-robot @dprotaso @googlebot