Add a new config-deployment parameter #7649
Conversation
this will guide how long are we allowing the deployment to take before we consider it failed. See knative#6201 for details. Also make lots of various clean ups in the config-default tests and the code itself. Next we'll theread it through rather than using constants all around.
|
@vagababov: GitHub didn't allow me to request PR reviews from the following users: yuzisun. Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
knative-prow-robot
added
the
size/L
There was a problem hiding this comment.
@vagababov: 0 warnings.
In response to this:
This will guide how long are we allowing the deployment to take
before we consider it failed.
See #6201 for details.This also moves the constant a bit, so a few file have to change.
Also internally make it duration so it's more self consistent.Also make lots of various clean ups in the config-default tests and the code itself.
Next we'll thread it through the code rather than using constants all around./lint
/assign mattmoor
/cc @yuzisun
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
vagababov
force-pushed
the
20200419-add-new-config-default
branch
from
66d7f0c
to
9a1a077
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes, mattmoor, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
vagababov
changed the title
This will guide how long are we allowing the deployment to take
before we consider it failed.
See #6201 for details.
This also moves the constant a bit, so a few file have to change.
Also internally make it duration so it's more self consistent.
Also make lots of various clean ups in the config-default tests and the code itself.
Next we'll thread it through the code rather than using constants all around.
/lint
/assign mattmoor
/cc @yuzisun