Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RELEASE-0.13] Backport KPA and Ingress bug fixes. #7833

Merged
merged 2 commits into from
May 5, 2020
Merged

[RELEASE-0.13] Backport KPA and Ingress bug fixes. #7833

merged 2 commits into from
May 5, 2020

Conversation

markusthoemmes
Copy link
Contributor

@markusthoemmes
Propagate Ingress status once ObservedGenerated matches generation. (k…
93a5099 
…native#7606)

Currently, status propagation is gated by both the ObservedGeneration check and a readiness check. In effect, as long as the Ingress is not ready, the route will always only show "IngressNotConfigured", which isn't super helpful to the user.

This lifts this check to allow the actual status from the Ingress to bubble up into the route (and thus into the Service potentially) to allow for finer grained diagnostics towards the user.
@markusthoemmes
Reconcile on all private service events in KPA. (knative#7514)
28a91df 
We used to have a metrics service which the KPA watched and reacted to. We got rid of that and now have a race condition if we specify minScale but the SKS becomes ready with less than minScale pods. Nothing after that will ever kick the KPA to reconcile again.

This fixes that by watching the private services to make sure the KPA sees every change in deployment size. It itself keys off of the private services too to calculate the current replicas, closing the loop here.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 4, 2020
@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 4, 2020
@knative-prow-robot knative-prow-robot added area/API API objects and controllers area/autoscale labels May 4, 2020
knative-prow-robot
knative-prow-robot reviewed May 4, 2020
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markusthoemmes: 0 warnings.

In response to this:

Proposed Changes

Release Note

NONE

/assign @mattmoor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added area/networking approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels May 4, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/autoscaling/kpa/controller.go 93.9% 94.1% 0.2

@mattmoor
Copy link
Member

mattmoor commented May 4, 2020

/assign @tcnghia @vagababov
/unassign

Assuming the ServiceType stuff wasn't changed in 13, this seems fine to me (should we backport further?). Both of these were in before the 14 cut, right?

@markusthoemmes
Copy link
Contributor Author

Yes, both are released via 0.14.

@vagababov
Copy link
Contributor

/lgtm
/hold
for @tcnghia

@knative-prow-robot knative-prow-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels May 4, 2020
@tcnghia
Copy link
Contributor

tcnghia commented May 5, 2020

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markusthoemmes
Copy link
Contributor Author

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2020
@knative-prow-robot knative-prow-robot merged commit dbbed9a into knative:release-0.13 May 5, 2020
@markusthoemmes markusthoemmes mentioned this pull request Jun 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@nak3 nak3 Awaiting requested review from nak3

@steuhs steuhs Awaiting requested review from steuhs

@vagababov vagababov Awaiting requested review from vagababov

Assignees

@tcnghia tcnghia

@vagababov vagababov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@markusthoemmes @knative-metrics-robot @mattmoor @vagababov @tcnghia @knative-prow-robot @googlebot