Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the build related stuff from v1alpha1 API #7896

Merged
merged 1 commit into from
May 9, 2020
Merged

Remove the build related stuff from v1alpha1 API #7896

merged 1 commit into from
May 9, 2020

Conversation

vagababov
Copy link
Contributor

Subj.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 8, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/API API objects and controllers labels May 8, 2020
@vagababov
Copy link
Contributor Author

/assign @dprotaso mattmoor

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/serving/v1alpha1/revision_lifecycle.go 89.3% 89.6% 0.2
pkg/apis/serving/v1alpha1/revision_validation.go 96.1% 95.6% -0.5

@dprotaso
Copy link
Member

dprotaso commented May 9, 2020

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2020
@vagababov
Copy link
Contributor Author

/test pull-knative-serving-integration-tests

@knative-prow-robot knative-prow-robot merged commit b1e4dde into knative:master May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@dprotaso dprotaso

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vagababov @knative-metrics-robot @dprotaso @knative-prow-robot @mattmoor @googlebot