Rename operation name for activator's proxy span and queue-proxy's span #7934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently both activator's proxy span and queue-proxy's proxy span have same name `proxy`. It is alright to see one trace data. But it is difficult to find/filter it by operation name. Hence, for example, if we want to find the trace which _activator is in the path_, we cannot filter it.
knative-prow-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
knative-prow-robot
added
size/S
|
The following jobs failed:
Automatically retrying due to test flakiness... |
| @@ -266,7 +266,7 @@ func TestActivationHandlerTraceSpans(t *testing.T) { | |||
| t.Errorf("Got %d spans, expected %d", len(gotSpans), tc.wantSpans) | |||
| } | |||
|
|
|||
| spanNames := []string{"throttler_try", "/", "proxy"} | |||
| spanNames := []string{"throttler_try", "/", "activator_proxy"} | |||
There was a problem hiding this comment.
Should we rename "throttler_try" to "activator_wait" while we're at it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This patch renames operation name for activator's proxy span and
queue-proxy's span.
Currently both activator's proxy span and queue-proxy's proxy span
have same name
proxyfor operatioin. It is alright to see the trace data.(We can distinguish the
proxy, but...)But it is difficult to find/filter it by the operation name.
(We cannot filter it as both are same name)
Hence, if we want to find the trace data which activator is/isn't in the path,
we cannot filter it.
Release Note