Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call MarkTLSNotEnabled for private cluster-local service #8043

Merged
merged 4 commits into from
May 26, 2020
Merged

Call MarkTLSNotEnabled for private cluster-local service #8043

merged 4 commits into from
May 26, 2020

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented May 22, 2020

Proposed Changes

#7163 propagates the status from KCert to Route when autoTLS is
enabled, but it introduced an issue.

When serving.knative.dev/visibility: cluster-local is configured,
KCert is not created and Route's cert status is not updated (=becomes
Unknwon status.)

To fix it, this patch calls MarkTLSNotEnabled when the service is
cluster-local.

/lint

Release Note

NONE

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 22, 2020
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/API API objects and controllers labels May 22, 2020
knative-prow-robot
knative-prow-robot reviewed May 22, 2020
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nak3: 0 warnings.

In response to this:

Proposed Changes

#7163 propagates the status from KCert to Route when autoTLS is
enabled, but it introduced an issue.

When serving.knative.dev/visibility: cluster-local is configured,
KCert is not created and Route's cert status is not updated (=becomes
Unknwon status.)

To fix it, this patch calls MarkTLSNotEnabled when the service is
cluster-local.

/lint

Release Note

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels May 22, 2020
@nak3
Copy link
Contributor Author

nak3 commented May 22, 2020

/test pull-knative-serving-https

I hope this fixes broken https test grid https://testgrid.knative.dev/serving#https

@nak3
Copy link
Contributor Author

nak3 commented May 22, 2020

/retest

Only TestServiceWithTrafficSplit failed. It works on my local so it might be a flake.

@nak3
Copy link
Contributor Author

nak3 commented May 22, 2020

/cc @tcnghia @ZhiminXiang @markusthoemmes

@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-integration-tests pull-knative-serving-integration-tests
pull-knative-serving-integration-tests
pull-knative-serving-integration-tests		 3/3

Automatically retrying due to test flakiness...
/test pull-knative-serving-integration-tests

@ZhiminXiang
Copy link

ZhiminXiang commented May 22, 2020 •
edited
Loading

@nak3 I think we may want to differentiate the below two cases and have different messages in Route status:

  1. auto TLS is not enabled
  2. auto TLS is enabled, but does not apply for cluster-local Route

WDYT?

@nak3
Copy link
Contributor Author

nak3 commented May 23, 2020

@ZhiminXiang Yes, that makes sense. We should have the different messages. Updated now.

/test pull-knative-serving-https

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/route/route.go 84.6% 84.9% 0.3

@ZhiminXiang
Copy link

/lgtm
/approve
/hold

I think we may want to check in this PR after the release cut.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2020
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2020
@markusthoemmes
Copy link
Contributor

/unhold

release is cut.

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2020
@tcnghia
Copy link
Contributor

tcnghia commented May 26, 2020

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, tcnghia, ZhiminXiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2020
@knative-prow-robot knative-prow-robot merged commit e88e1d6 into knative:master May 26, 2020
@nak3 nak3 deleted the fix-cluster-local-tls branch June 30, 2020 13:57
@amarflybot amarflybot mentioned this pull request Jan 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@coryrc coryrc Awaiting requested review from coryrc

@yanweiguo yanweiguo Awaiting requested review from yanweiguo

@markusthoemmes markusthoemmes Awaiting requested review from markusthoemmes

@tcnghia tcnghia Awaiting requested review from tcnghia

@ZhiminXiang ZhiminXiang Awaiting requested review from ZhiminXiang

Assignees

@ZhiminXiang ZhiminXiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@nak3 @knative-test-reporter-robot @ZhiminXiang @knative-metrics-robot @markusthoemmes @tcnghia @knative-prow-robot @googlebot