Grant @elafros/elafros-maintainers CODEOWNERS over the entire repo. #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evankanderson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
approved
|
/assign mattmoor |
mattmoor
approved these changes
May 7, 2018
|
/lgtm |
|
/retest |
This was referenced May 8, 2018
markusthoemmes
pushed a commit
to markusthoemmes/knative-serving
that referenced
this pull request
Aug 24, 2021
* Add HPA test * Longer timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implicit Governance Change -- this is granting the technical oversight committee (ToC) direct
CODEOWNERSon all files in the repo. Previously, a PR (like this one) would be needed for the ToC to getCODEOWNERSaccess to a subdirectory owned by a working group.In reference to #543, but not fixing it.
Proposed Changes
@evankanderson @mattmoor @vaikas-googleto a reference to the elafros-maintainers group.CODEOWNERSon all files; this prevents the case where Prow approvals are granted (becauseOWNERSare hierarchical). This prevents Tide from getting backed up merging PRs that don't haveCODEOWNERSapproval.