Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the default periodSeconds to 10s. #8148

Merged
merged 1 commit into from
Jun 1, 2020
Merged

Bump the default periodSeconds to 10s. #8148

merged 1 commit into from
Jun 1, 2020

Conversation

mattmoor
Copy link
Member

@mattmoor mattmoor commented Jun 1, 2020

Fixes: #8147

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 1, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 1, 2020
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/API API objects and controllers area/networking approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 1, 2020
@mattmoor mattmoor mentioned this pull request Jun 1, 2020
Closed
@mattmoor
Copy link
Member Author

mattmoor commented Jun 1, 2020

/retest

@vagababov
Copy link
Contributor

/lgtm
/hold
If anyone else wants to look at this.
/retest

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2020
@mattmoor
Copy link
Member Author

mattmoor commented Jun 1, 2020

/test pull-knative-serving-integration-tests

@mattmoor
Copy link
Member Author

mattmoor commented Jun 1, 2020

One more for good measure:
/test pull-knative-serving-integration-tests

shashwathi
shashwathi approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@shashwathi shashwathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, shashwathi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mattmoor
Copy link
Member Author

mattmoor commented Jun 1, 2020

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 1, 2020
@knative-prow-robot knative-prow-robot merged commit 2247211 into knative:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shashwathi shashwathi shashwathi approved these changes

@JRBANCEL JRBANCEL Awaiting requested review from JRBANCEL

@tcnghia tcnghia Awaiting requested review from tcnghia

Assignees

@dprotaso dprotaso

@tcnghia tcnghia

@vagababov vagababov

@shashwathi shashwathi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/networking cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

High CPU usage for idle queue-proxy
7 participants
@mattmoor @vagababov @knative-prow-robot @shashwathi @dprotaso @tcnghia @googlebot