Install latest release of net-istio whenever we install latest release of serving. #8158
Conversation
knative-prow-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tcnghia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
area/test-and-release
tcnghia
changed the title
|
Cross posting from the issue: @tcnghia tbh I'd rather go with the checked in third_party version to have control over what gets tested when. If not, we should ditch the third_party file entirely and always rely on the latest release from net-istio. |
|
@markusthoemmes that was my first thought, but I changed my mind because our users, if following the doc pages today, would start with both release versions of serving and net-istio. So here we try best to simulate their experience. If there is an issue upgrading from that setup, we need to know. In the other case, using the net-istio nightly from the third_party directory is similar to "building net-istio at HEAD", which is also consistent with "building Serving at HEAD". |
| @@ -319,7 +328,18 @@ function install_knative_serving_standard() { | |||
| elif [[ -n "${CONTOUR_VERSION}" ]]; then | |||
| install_contour || return 1 | |||
| else | |||
| install_istio "./third_party/net-istio.yaml" || return 1 | |||
| if [[ "$1" == "HEAD" ]]; then | |||
| install_istio "./third_party/net-istio.yaml" || return 1 | |||
There was a problem hiding this comment.
As we discussed yesterday, shall we install the latest nightly release here?
There was a problem hiding this comment.
I think this is from the latest nightly release?
Otherwise, what is the URL to get the latest nightly release? thanks
There was a problem hiding this comment.
Since there is already a lot of bash in this PR, I'd do that in a follow up.
Co-authored-by: Chi Zhang <chizhg@google.com>
Co-authored-by: Chi Zhang <chizhg@google.com>
|
So @chizhg and @markusthoemmes: I think we can try to get rid of the third_party file, but my guess is that it may increase problems in our presubmit. I am open to trying it out (in a nother PR) to see if my guess is true though. Worst case we can go back to where we are. |
|
/lgtm |
Fixes #8153
Proposed Changes
Release Note
/assign @chizhg