Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert special cases fat-image handling as CRI-O fixes have been rolled out. #8192

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

markusthoemmes
Copy link
Contributor

@markusthoemmes markusthoemmes commented Jun 4, 2020

Fixes #3997

Proposed Changes

This reverts the commits 5eded04 and ce9bdcb.

This has been rolled out at least since CRI-O 1.16.0, which translates to Openshift 4.3 which is the lowest supported version for Openshift Serverless currently. It's safe to rely on this at this point it seems.

I hope I understood the special-casing correctly in that this change won't break the schema1 handling again 🤔.

Release Note

NONE

/assign @mattmoor @jonjohnsonjr
/hold

If CI passes I'll build a version of this to run through our downstream CI, just to add an extra level of confidence.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 4, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/API API objects and controllers labels Jun 4, 2020
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markusthoemmes: 0 warnings.

In response to this:

Fixes #

Proposed Changes

This reverts the commits 5eded04 and ce9bdcb.

This has been rolled out at least since CRI-O 1.16.0, which translates to Openshift 4.3 which is the lowest supported version for Openshift Serverless currently. It's safe to rely on this at this point it seems.

I hope I understood the special-casing correctly in that this change won't break the schema1 handling again 🤔.

Release Note

NONE

/assign @mattmoor @jonjohnsonjr
/hold

If CI passes I'll build a version of this to run through our downstream CI, just to add an extra level of confidence.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/revision/resolve.go 90.3% 95.5% 5.1

@jonjohnsonjr
Copy link
Contributor

LGTM, but your PR should say Fixes #3997.

@mattmoor
Copy link
Member

mattmoor commented Jun 5, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2020
@markusthoemmes
Copy link
Contributor Author

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2020
@knative-prow-robot knative-prow-robot merged commit a1a08f4 into knative:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manifest list resolution breaks CRI-O based clusters
6 participants