-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert special cases fat-image handling as CRI-O fixes have been rolled out. #8192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markusthoemmes: 0 warnings.
In response to this:
Fixes #
Proposed Changes
This reverts the commits 5eded04 and ce9bdcb.
This has been rolled out at least since CRI-O 1.16.0, which translates to Openshift 4.3 which is the lowest supported version for Openshift Serverless currently. It's safe to rely on this at this point it seems.
I hope I understood the special-casing correctly in that this change won't break the schema1 handling again 🤔.
Release Note
NONE
/assign @mattmoor @jonjohnsonjr
/holdIf CI passes I'll build a version of this to run through our downstream CI, just to add an extra level of confidence.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The following is the coverage report on the affected files.
|
LGTM, but your PR should say |
/lgtm |
/hold cancel |
Fixes #3997
Proposed Changes
This reverts the commits 5eded04 and ce9bdcb.
This has been rolled out at least since CRI-O 1.16.0, which translates to Openshift 4.3 which is the lowest supported version for Openshift Serverless currently. It's safe to rely on this at this point it seems.
I hope I understood the special-casing correctly in that this change won't break the schema1 handling again 🤔.
Release Note
/assign @mattmoor @jonjohnsonjr
/hold
If CI passes I'll build a version of this to run through our downstream CI, just to add an extra level of confidence.