Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autoscaler ConfigMap to revision reconciler and create deployment with initial scale #8355

Merged
merged 4 commits into from
Jun 22, 2020
Merged

Add autoscaler ConfigMap to revision reconciler and create deployment with initial scale #8355

merged 4 commits into from
Jun 22, 2020

Conversation

taragu
Copy link
Contributor

@taragu taragu commented Jun 17, 2020

/lint

Part 6 of #7682

Proposed Changes

  • Adding back the autoscaler ConfigMap to revision reconciler
  • Pass in the autoscaler ConfigMap to MakeDeployment in order to create the initial replica count with initial scale

Release Note

NONE

/cc @julz @vagababov @markusthoemmes @dprotaso @mattmoor

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 17, 2020
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/API API objects and controllers labels Jun 17, 2020
knative-prow-robot
knative-prow-robot reviewed Jun 17, 2020
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taragu: 0 warnings.

In response to this:

/lint

Part 6 of #7682

Proposed Changes

  • Adding back the autoscaler ConfigMap to revision reconciler
  • Pass in the autoscaler ConfigMap to MakeDeployment in order to create the initial replica count with initial scale

Release Note

NONE

/cc @julz @vagababov @markusthoemmes @dprotaso @mattmoor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@taragu
Copy link
Contributor Author

taragu commented Jun 17, 2020

/retest

@vagababov
Copy link
Contributor

we can't kill this one, can we 😆
I just removed it and we removed at some point earlier...

@julz
Copy link
Member

julz commented Jun 17, 2020

@vagababov let's add a comment this time "don't remove, it will only come back" ;)

@vagababov
Copy link
Contributor

Zombie CM.

vagababov
vagababov reviewed Jun 17, 2020
View reviewed changes
pkg/reconciler/revision/config/store.go Outdated Show resolved Hide resolved
pkg/reconciler/revision/resources/deploy.go Outdated Show resolved Hide resolved
pkg/reconciler/revision/resources/deploy.go Outdated Show resolved Hide resolved
pkg/reconciler/revision/resources/deploy.go Outdated Show resolved Hide resolved
pkg/reconciler/revision/resources/deploy_test.go Outdated Show resolved Hide resolved
@taragu
Copy link
Contributor Author

taragu commented Jun 18, 2020

/hold
for #8353

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/revision/resources/deploy.go 100.0% 98.5% -1.5

@taragu taragu force-pushed the tara-init-scale-0-add-AS-configmap branch from f0f63c4 to 4e28d00 Compare June 18, 2020 20:59
@taragu
Copy link
Contributor Author

taragu commented Jun 18, 2020

/hold cancel

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2020
vagababov
vagababov reviewed Jun 18, 2020
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @dprotaso

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2020
julz
julz reviewed Jun 19, 2020
View reviewed changes
Copy link
Member

@julz julz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dprotaso
Copy link
Member

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, taragu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2020
@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-integration-tests:

test/conformance/api/v1alpha1.TestRevisionTimeout

@taragu
Copy link
Contributor Author

taragu commented Jun 22, 2020

/retest

@knative-prow-robot knative-prow-robot merged commit bb86c79 into knative:master Jun 22, 2020
@taragu taragu deleted the tara-init-scale-0-add-AS-configmap branch July 29, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@vagababov vagababov vagababov left review comments

@julz julz julz left review comments

@dprotaso dprotaso Awaiting requested review from dprotaso

@markusthoemmes markusthoemmes Awaiting requested review from markusthoemmes

@mattmoor mattmoor Awaiting requested review from mattmoor

Assignees

@dprotaso dprotaso

@julz julz

@vagababov vagababov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@taragu @vagababov @julz @knative-metrics-robot @dprotaso @knative-prow-robot @knative-test-reporter-robot @googlebot