Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop use of unsupported resource locks from the leaderelection example config #8565

Merged
merged 1 commit into from
Jul 6, 2020
Merged

drop use of unsupported resource locks from the leaderelection example config #8565

merged 1 commit into from
Jul 6, 2020

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Jul 6, 2020

Proposed Changes

  • knative.dev/pkg only supports lease locks given our minimum K8s now has the v1 coordination API

Release Note

Leader election config only supports lease locks

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 6, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 6, 2020
@knative-prow-robot knative-prow-robot added the area/API API objects and controllers label Jul 6, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2020
vagababov
vagababov reviewed Jul 6, 2020
View reviewed changes
Copy link
Contributor

@vagababov vagababov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2020
@dprotaso
Copy link
Member Author

dprotaso commented Jul 6, 2020

/retest

@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-autotls-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-autotls-tests:

test/e2e/autotls.TestAutoTLS
test/e2e/autotls.TestAutoTLS/HTTP01

@dprotaso
Copy link
Member Author

dprotaso commented Jul 6, 2020

/retest

@knative-prow-robot knative-prow-robot merged commit 77c03f0 into knative:master Jul 6, 2020
@dprotaso dprotaso deleted the drop-locks branch July 6, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vagababov vagababov vagababov left review comments

@mdemirhan mdemirhan Awaiting requested review from mdemirhan

Assignees

@vagababov vagababov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dprotaso @knative-prow-robot @knative-test-reporter-robot @vagababov @googlebot