Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge pkg to serving #8686

Merged
merged 2 commits into from
Jul 18, 2020
Merged

Merge pkg to serving #8686

merged 2 commits into from
Jul 18, 2020

Conversation

vagababov
Copy link
Contributor

/assign mattmoor

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 18, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 18, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2020
@mattmoor
Copy link
Member

Wanna pull in: knative/pkg#1517?

@yanweiguo
Copy link
Contributor

/retest

@yanweiguo
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2020
@knative-prow-robot knative-prow-robot merged commit 66fc60d into knative:master Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprotaso dprotaso Awaiting requested review from dprotaso

@mattmoor mattmoor Awaiting requested review from mattmoor

Assignees

@mattmoor mattmoor

@yanweiguo yanweiguo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vagababov @knative-prow-robot @mattmoor @yanweiguo @googlebot