Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid go test caching when running conformance tests #881

Merged
merged 1 commit into from
May 11, 2018
Merged

Avoid go test caching when running conformance tests #881

merged 1 commit into from
May 11, 2018

Conversation

glyn
Copy link
Contributor

@glyn glyn commented May 11, 2018

Go test caching causes the second and subsequent runs of the conformance tests
to be skipped even though changes may have been made to the system under test.

According to go help test, the idiomatic way to disable test caching
explicitly is to use -count=1.

@glyn glyn requested a review from a team May 11, 2018 11:31
@google-prow-robot google-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 11, 2018
@glyn glyn changed the title Avoid go test caching whn running conformance tests Avoid go test caching when running conformance tests May 11, 2018
Go test caching causes the second and subsequent runs of the conformance tests
to be skipped even though changes may have been made to the system under test.

According to `go help test`, the idiomatic way to disable test caching
explicitly is to use -count=1.
@glyn
Copy link
Contributor Author

glyn commented May 11, 2018

/assign @bobcatfish

@glyn
Copy link
Contributor Author

glyn commented May 11, 2018

I only changed a README.

/retest

@glyn
Copy link
Contributor Author

glyn commented May 11, 2018

Thanks to @trisberg for a link to Viewing test logs. The conformance tests failed with:

route_test.go:123: The endpoint for Route pizzaplanet at domain pizzaplanet.pizzaplanet.demo-domain.com didn't serve the expected text "What a spaceport!": Get http://35.232.200.209: dial tcp 35.232.200.209:80: i/o timeout

There seems to be a problem of test flakiness, already captured in issue 879.

@adrcunha
Copy link
Contributor

I only changed a README.

Currently the tests run for all changes. #815 tracks the effort to optimized that.

@adrcunha
Copy link
Contributor

/retest
/lgtm
/approve

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2018
@google-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, glyn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2018
@glyn
Copy link
Contributor Author

glyn commented May 11, 2018

@adrcunha prow approved this PR an hour ago. Should I just be patient or is there some reason the merge isn't happening?

@adrcunha
Copy link
Contributor

Looks like #876 is blocking tide (this is tracked by #543). You can merge it automatically if you want, no problem.

@grantr grantr merged commit 36a3833 into knative:master May 11, 2018
@glyn
Copy link
Contributor Author

glyn commented May 11, 2018

Thanks @adrcunha. Looks like tide is another google-internal thing I can't see yet. ;-)

@grantr Thanks for merging.

@glyn glyn deleted the do-not-cache-conformance-tests branch June 27, 2018 10:12
markusthoemmes added a commit to markusthoemmes/knative-serving that referenced this pull request Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants