-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid go test caching when running conformance tests #881
Conversation
Go test caching causes the second and subsequent runs of the conformance tests to be skipped even though changes may have been made to the system under test. According to `go help test`, the idiomatic way to disable test caching explicitly is to use -count=1.
/assign @bobcatfish |
I only changed a README. /retest |
Thanks to @trisberg for a link to Viewing test logs. The conformance tests failed with:
There seems to be a problem of test flakiness, already captured in issue 879. |
Currently the tests run for all changes. #815 tracks the effort to optimized that. |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha, glyn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@adrcunha prow approved this PR an hour ago. Should I just be patient or is there some reason the merge isn't happening? |
Go test caching causes the second and subsequent runs of the conformance tests
to be skipped even though changes may have been made to the system under test.
According to
go help test
, the idiomatic way to disable test cachingexplicitly is to use -count=1.