-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull in depcheck, start queue-proxy blocklist #9954
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Codecov Report
@@ Coverage Diff @@
## master #9954 +/- ##
==========================================
+ Coverage 87.78% 87.83% +0.04%
==========================================
Files 183 183
Lines 8631 8631
==========================================
+ Hits 7577 7581 +4
+ Misses 802 800 -2
+ Partials 252 250 -2
Continue to review full report at Codecov.
|
@mattmoor can we add a tracking issue and mention in your TODO to make clear what we try to achieve here? I think the context was mainly on Slack and may evade someones who only look at the code / failing tests when they create a seemingly harmless PR. |
Yeah, I just opened #9957 let's part there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, tcnghia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cc @dprotaso @tcnghia @vagababov
As we pick apart the binary and find others that shouldn't be here, let's expand.