-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buoy: cut extra URL path for module #13
Conversation
Some module use sub-directory for the module like https://github.com/blang/semver/tree/master/v4 In that case, buoy fails to fetch metadata with the full path: ``` $ curl https://github.com/blang/semver/v4?go-get=1 ``` so needs to use the top directory and path. ``` $ curl https://github.com/blang/semver?go-get=1 ``` Hence, this patch cuts extra URL path for module.
Background issue is knative/pkg#2759 (comment) |
/cc @kvmware |
@nak3: GitHub didn't allow me to request PR reviews from the following users: kv. Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@nak3 note that the changes to hack you identified (in slack) will have to be done too if you want to pick up these changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Don't forget to update knative/hack to use install bouy from this repo.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Some module use sub-directory for the module like https://github.com/blang/semver/tree/master/v4
In that case, buoy fails to fetch metadata with the full path:
so needs to use the top directory and path.
Hence, this patch cuts extra URL path for module.