Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support window is now only two releases #27

Merged
merged 1 commit into from
Feb 13, 2024
Merged

support window is now only two releases #27

merged 1 commit into from
Feb 13, 2024

Conversation

dprotaso
Copy link
Member

Support window is actually two release not three

/assign @upodroid @krsna-m

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 12, 2024
@dprotaso
Copy link
Member Author

Linter issue fixed in - #26

upodroid
upodroid approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Feb 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Member Author

/override "style / Golang / Auto-format and Check"

@knative-prow Knative Prow
Copy link

knative-prow bot commented Feb 13, 2024

@dprotaso: Overrode contexts on behalf of dprotaso: style / Golang / Auto-format and Check

In response to this:

/override "style / Golang / Auto-format and Check"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit cdf9cf6 into knative:main Feb 13, 2024
23 of 24 checks passed
@dprotaso dprotaso deleted the support-window-two-releases branch February 13, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid approved these changes

@cardil cardil Awaiting requested review from cardil

@mgencur mgencur Awaiting requested review from mgencur

Assignees

@upodroid upodroid

@krsna-m krsna-m

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dprotaso @upodroid @krsna-m