Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve excluded folders handling for better performance and extensibility #29

Merged
merged 1 commit into from
May 22, 2024
Merged

Improve excluded folders handling for better performance and extensibility #29

merged 1 commit into from
May 22, 2024

Conversation

sig-seg-v13
Copy link
Contributor

This pull request addresses several improvements to the way excluded folders are handled in the scanGitFolders function.

Changes:

  1. Replaced the excludedFolders slice with a map[string]bool for constant-time lookups, improving performance.
  2. Converted folder names to lowercase before checking for exclusion, ensuring case-insensitivity.
  3. Made the excludedFolders map extensible, allowing for easy addition or removal of folder names to exclude.

@knbr13 knbr13 merged commit e4bd8a9 into knbr13:main May 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knbr13 knbr13 knbr13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sig-seg-v13 @knbr13