Skip to content

Fork of coopernurse's generic-pool, with some refactoring & api changes.

Notifications You must be signed in to change notification settings

knex/generic-pool-redux

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 
 
 
 
 
 
 
 
 
 
 
 
 

Repository files navigation

About

Forked from generic pool, it can be used to reuse or throttle expensive resources such as database connections.

Build Status

Example

Step 1 - Create pool using a factory object

// Create a MySQL connection pool with
// a max of 10 connections, a min of 2, and a 30 second max idle time
var poolModule = require('generic-pool');
var pool = poolModule.Pool({
    name     : 'mysql',
    create   : function(callback) {
        var Client = require('mysql').Client;
        var c = new Client();
        c.user     = 'scott';
        c.password = 'tiger';
        c.database = 'mydb';
        c.connect();
        callback(null, c);
    },
    destroy  : function(client) { client.end(); },
    max      : 10,
    // optional. if you set this, make sure to drain() (see step 3)
    min      : 2,
    // specifies how long a resource can stay idle in pool before being removed
    idleTimeoutMillis : 30000,
     // if true, logs via console.log - can also be a function
    log : true
});

Step 2 - Use pool in your code to acquire/release resources

// acquire connection - callback function is called
// once a resource becomes available
pool.acquire(function(err, client) {
    if (err) {
        // handle error - this is generally the err from your
        // factory.create function
    }
    else {
        client.query("select * from foo", [], function() {
            // return object back to pool
            pool.release(client);
        });
    }
});

Step 3 - Drain pool during shutdown (optional)

If you are shutting down a long-lived process, you may notice that node fails to exit for 30 seconds or so. This is a side effect of the idleTimeoutMillis behavior -- the pool has a setTimeout() call registered that is in the event loop queue, so node won't terminate until all resources have timed out, and the pool stops trying to manage them.

This behavior will be more problematic when you set factory.min > 0, as the pool will never become empty, and the setTimeout calls will never end.

In these cases, use the pool.drain() function. This sets the pool into a "draining" state which will gracefully wait until all idle resources have timed out. For example, you can call:

// Only call this once in your application -- at the point you want
// to shutdown and stop using this pool.
pool.drain(function() {
    pool.destroyAllNow();
});

If you do this, your node process will exit gracefully.

Documentation

Pool() accepts an object with these slots:

              name : name of pool (string, optional)
            create : function that returns a new resource
                       should call callback() with the created resource
           destroy : function that accepts a resource and destroys it
               max : maximum number of resources to create at any given time
                     optional (default=1)
               min : minimum number of resources to keep in pool at any given time
                     if this is set > max, the pool will silently set the min
                     to factory.max - 1
                     optional (default=0)
       refreshIdle : boolean that specifies whether idle resources at or below the min threshold
                     should be destroyed/re-created.  optional (default=true)
 idleTimeoutMillis : max milliseconds a resource can go unused before it should be destroyed
                     (default 30000)
reapIntervalMillis : frequency to check for idle resources (default 1000),
     priorityRange : int between 1 and x - if set, borrowers can specify their
                     relative priority in the queue if no resources are available.
                     see example.  (default 1)
          validate : function that accepts a pooled resource and returns true if the resource
                     is OK to use, or false if the object is invalid.  Invalid objects will be destroyed.
                     This function is called in acquire() before returning a resource from the pool.
                     Optional.  Default function always returns true.

Priority Queueing

The pool now supports optional priority queueing. This becomes relevant when no resources are available and the caller has to wait. acquire() accepts an optional priority int which specifies the caller's relative position in the queue.

 // create pool with priorityRange of 3
 // borrowers can specify a priority 0 to 2
 var pool = poolModule.Pool({
     name     : 'mysql',
     create   : function(callback) {
         // do something
     },
     destroy  : function(client) {
         // cleanup.  omitted for this example
     },
     max      : 10,
     idleTimeoutMillis : 30000,
     priorityRange : 3
 });

 // acquire connection - no priority - will go at end of line
 pool.acquire(function(err, client) {
     pool.release(client);
 });

 // acquire connection - high priority - will go into front slot
 pool.acquire(function(err, client) {
     pool.release(client);
 }, 0);

 // acquire connection - medium priority - will go into middle slot
 pool.acquire(function(err, client) {
     pool.release(client);
 }, 1);

 // etc..

Draining

If you know would like to terminate all the resources in your pool before their timeouts have been reached, you can use destroyAllNow() in conjunction with drain():

pool.drain(function() {
    pool.destroyAllNow();
});

One side-effect of calling drain() is that subsequent calls to acquire() will throw an Error.

Pooled function decoration

To transparently handle object acquisition for a function, one can use pooled():

var privateFn, publicFn;
publicFn = pool.pooled(privateFn = function(client, arg, cb) {
    // Do something with the client and arg. Client is auto-released when cb is called
    cb(null, arg);
});

Keeping both private and public versions of each function allows for pooled functions to call other pooled functions with the same member. This is a handy pattern for database transactions:

var privateTop, privateBottom, publicTop, publicBottom;
publicBottom = pool.pooled(privateBottom = function(client, arg, cb) {
    //Use client, assumed auto-release
});

publicTop = pool.pooled(privateTop = function(client, cb) {
    // e.g., open a database transaction
    privateBottom(client, "arg", function(err, retVal) {
        if(err) { return cb(err); }
        // e.g., close a transaction
        cb();
    });
});

Run Tests

$ npm install expresso
$ expresso -I lib test/*.js

Generic Pool Redux

0.1.0 - Sepember 13 2013
    - Rewriting the API to use prototypes, remove logging, added a callback on release, for consistency.

Generic Pool History (old fork)

2.0.4 - July 27 2013
   - Merged #64 - Fix for not removing idle objects (contributed by PiotrWpl)

2.0.3 - January 16 2013
   - Merged #56/#57 - Add optional refreshIdle flag. If false, idle resources at the pool minimum will not be
     destroyed/re-created. (contributed by wshaver)
   - Merged #54 - Factory can be asked to validate pooled objects (contributed by tikonen)

2.0.2 - October 22 2012
   - Fix #51, #48 - createResource() should check for null clientCb in err case (contributed by pooyasencha)
   - Merged #52 - fix bug of infinite wait when create object aync error (contributed by windyrobin)
   - Merged #53 - change the position of dispense and callback to ensure the time order (contributed by windyrobin)

2.0.1 - August 29 2012
   - Fix #44 - leak of 'err' and 'obj' in createResource()
   - Add devDependencies block to package.json
   - Add travis-ci.org integration

2.0.0 - July 31 2012
   - Non-backwards compatible change: remove adjustCallback
      - acquire() callback must accept two params: (err, obj)
   - Add optional 'min' param to factory object that specifies minimum number of
     resources to keep in pool
   - Merged #38 (package.json/Makefile changes - contributed by strk)

1.0.12 - June 27 2012
   - Merged #37 (Clear remove idle timer after destroyAllNow - contributed by dougwilson)

1.0.11 - June 17 2012
   - Merged #36 ("pooled" method to perform function decoration for pooled methods - contributed by cosbynator)

1.0.10 - May 3 2012
   - Merged #35 (Remove client from availbleObjects on destroy(client) - contributed by blax)

1.0.9 - Dec 18 2011
   - Merged #25 (add getName() - contributed by BryanDonovan)
   - Merged #27 (remove sys import - contributed by botker)
   - Merged #26 (log levels - contributed by JoeZ99)

1.0.8 - Nov 16 2011
   - Merged #21 (add getter methods to see pool size, etc. - contributed by BryanDonovan)

1.0.7 - Oct 17 2011
   - Merged #19 (prevent release on the same obj twice - contributed by tkrynski)
   - Merged #20 (acquire() returns boolean indicating whether pool is full - contributed by tilgovi)

1.0.6 - May 23 2011
   - Merged #13 (support error variable in acquire callback - contributed by tmcw)
      - Note: This change is backwards compatible.  But new code should use the two
              parameter callback format in pool.create() functions from now on.
   - Merged #15 (variable scope issue in dispense() - contributed by eevans)

1.0.5 - Apr 20 2011
   - Merged #12 (ability to drain pool - contributed by gdusbabek)

1.0.4 - Jan 25 2011
   - Fixed #6 (objects reaped with undefined timeouts)
   - Fixed #7 (objectTimeout issue)

1.0.3 - Dec 9 2010
   - Added priority queueing (thanks to sylvinus)
   - Contributions from Poetro
     - Name changes to match conventions described here: http://en.wikipedia.org/wiki/Object_pool_pattern
        - borrow() renamed to acquire()
        - returnToPool() renamed to release()
     - destroy() removed from public interface
     - added JsDoc comments
     - Priority queueing enhancements

1.0.2 - Nov 9 2010
   - First NPM release

License

(The MIT License)

Copyright (c) 2010-2013 James Cooper <james@bitmechanic.com>

Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the 'Software'), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

About

Fork of coopernurse's generic-pool, with some refactoring & api changes.

Resources

Stars

Watchers

Forks

Releases

No releases published

Packages

No packages published