Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #94 #127

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Closes #94 #127

wants to merge 5 commits into from

Conversation

ozziest
Copy link

@ozziest ozziest commented Sep 9, 2022

Hello everyone,

I intend to solve this issue (#94) while I have some free time. But I am gonna need some help.
I rebased the latest version of knex-schema-inspector. But in the pipeline, I see the following errors;

1) sqlite
       .columnInfo
         returns information for all columns in all tables:
     SqliteError: select `name` from `sqlite_master` where sql LIKE "%AUTOINCREMENT%" - no such column: %AUTOINCREMENT%
      at Database.prepare (node_modules/better-sqlite3/lib/methods/wrappers.js:5:21)
      at Client_BetterSQLite3._query (node_modules/knex/lib/dialects/better-sqlite3/index.js:30:34)
      at executeQuery (node_modules/knex/lib/execution/internal/query-executioner.js:37:17)
      at Client_BetterSQLite3.query (node_modules/knex/lib/client.js:146:12)
      at Runner.query (node_modules/knex/lib/execution/runner.js:130:36)
      at ensureConnectionCallback (node_modules/knex/lib/execution/internal/ensure-connection-callback.js:13:17)
      at Runner.ensureConnection (node_modules/knex/lib/execution/runner.js:307:20)
      at Runner.run (node_modules/knex/lib/execution/runner.js:30:19)

https://github.com/knex/knex-schema-inspector/runs/8266354215?check_suite_focus=true#step:10:197

At this point, what should I do?

  1. Should I extend dialects/sqlite.ts file?
  2. Should I work on the dialects/sqlite.ts file, and implement the changes for Client_SQLite3?

Also, should I use the same test file or create a new one for the better-sqlite?

@ozziest
Copy link
Author

ozziest commented Sep 10, 2022

@kibertoad, can you review this, please?

test/sqlite.spec.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants