Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typography resets #27

Closed
dbox opened this issue Jun 6, 2016 · 0 comments
Closed

typography resets #27

dbox opened this issue Jun 6, 2016 · 0 comments

Comments

@dbox
Copy link
Contributor

dbox commented Jun 6, 2016

h1, h2, h3, h4, h5, h6 {
  display: block;
  margin: 1rem 0;
  font-weight: normal;

  &:first-child {
    margin-top: 0;
  }

  a { color: inherit;  }
}

If we're adding this to every project, then perhaps there should be an additive mixin in knapsack for this.

Need to look into this too:

// Global responsive typography - edit per project
// Type will be fluid between min and max sizes
// See mixin fluid-type() in Knapsack

h1 { @include fluid-type(36px, 56px, 420px, 1024px); }
h2 { @include fluid-type(36px, 48px, 420px, 1024px); }
h3 { @include fluid-type(30px, 36px, 420px, 1024px); }
h4 { @include fluid-type(24px, 30px, 420px, 1024px); }
h5 { @include fluid-type(20px, 24px, 420px, 1024px); }
h6 { @include fluid-type(18px, 20px, 420px, 1024px); }
p, ul, li, ol { @include fluid-type(15px, 18px);}

As I think it could cause some bloat.

dbox added a commit that referenced this issue Jul 15, 2016
@dbox dbox closed this as completed Jul 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant