-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better calc detection & fallback, code optimisations & cleanup #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…minifiers strip the first one out
Added to dev branch. will be pushed with next release. thanks! |
Would you mind resubmitting this to the dev branch? Thanks! |
@aicarlson Want to look at this and see if you can get it merged cleanly into latest? |
@dbox Sure, I'll take a look later tonight. |
Conflicts: index.html js/rrssb.js js/rrssb.min.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I apologise in advance if I was meant to create separate pull requests for these changes. This is my first on github.
Commit: 4d9a3a8
For some unknown reason, when the parent element to the rrssb-buttons element has a percentage padding left & right, with the calc polyfill in place and the child elements widths add up to that of the parent, the last element will wrap to a newline. The 1px saftey net sorts that issue out.
Edit: The issue was caused by browsers rounding fractional pixel widths to the nearest whole pixel. This means you can end up in a situation where the width of the element is reported to be larger than it actually is. The only consistent way I can see is to - 1 off the width given. You can get the fractional width by using $('.something')[0].getBoundingClientRect().width but unfortunately .width is undefined in <= IE8.