Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move optional services #127

Merged
merged 8 commits into from
Mar 10, 2024
Merged

Move optional services #127

merged 8 commits into from
Mar 10, 2024

Conversation

purple-emily
Copy link
Collaborator

@iPromKnight Can you check Grafana to make sure it maps correctly to the .env file? Someone in Discord last night had an issue. I've attempted to fix it but would like verification it works

@purple-emily purple-emily requested a review from iPromKnight March 9, 2024 14:10
@purple-emily
Copy link
Collaborator Author

The .gitkeep mapping isn't working in the .gitignore. Any ideas?

@iPromKnight
Copy link
Collaborator

I'll take a look
I run it myself from whats in git so it should
Will check gitignore too

@iPromKnight iPromKnight force-pushed the move-optional-services branch from fe4c819 to b7cc35b Compare March 10, 2024 00:43
Copy link
Collaborator

@iPromKnight iPromKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few more things to the gitignore, and sorted the .gitkeep in the logs folder, also rebased on master - LGTM, Merging

@iPromKnight iPromKnight merged commit 0b3000a into master Mar 10, 2024
3 checks passed
@iPromKnight iPromKnight deleted the move-optional-services branch March 10, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants