chore: make react* sdks react 19 compatible #348
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
packages/react/src/modules/feed/components/NotificationFeedPopover/NotificationFeedPopover.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes aimed to add support for React 19 with the
reactandreact-corepackages.The first immediate thing is there are several external dependencies in
reactandreact-corethat need be updated to the latest versions so they support or allow react 19 as a peer dependency.There was one exception to this which was
react-popper- the react-popper project was deprecated earlier last year in favor of a new project floating-ui as a successor. The last react-popper version has react 18 as a peer dependency so we need to migrate to the new floating-ui lib, but the API has changed slightly so it involved some code changes.There are a few remaining questions/issues:
react-popper-tooltipfromreactfor the same reason explained above.react-popper-tooltipitself accepts react 19, but it has a dependency to react-popper 2.3.0, which has a deep dep up to react 18.reactand@types/reactto 19 in ourreact-corepackage, and the type check was failing and a couple of the errors were coming from zustand func calls. My first thought was to upgradezustandto the latest and make any necessary changes, but I realized we are quite behind and I vaguely remember us having issues upgradingzustand?I think the ideal solution is to resolve the issues above, but still keep react and react-dom deps for dev in our packages still at 18 because it seems like our monorepo setup forces a single consistent version across all of our packages and example apps, and upgrading them may be too big of a lift.