feat(kno-3079): idempotency keys for workflow triggers #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentjanderson
requested review from
cjbell,
juanazam,
thomaswhyyou,
bceskavich and
meryldakin
cjbell
reviewed
Apr 4, 2023
lib/knock/api.ex
Outdated
| ] | ||
|
|
||
| Tesla.client(middleware, config.adapter) | ||
| end | ||
|
|
||
| defp maybe_idempotency_key_header(idempotency_key: key), do: [{"Idempotency-Key", key}] |
There was a problem hiding this comment.
One note here: prefer passing the opts as a map if you want to match like this, otherwise multiple keys in this list won't match as expected
meryldakin
approved these changes
Apr 6, 2023
brentjanderson
deleted the
brent-kno-3079-sdk-add-idempotence-header-to-elixir-sdk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.