Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arrayFirst returns undefined if found value is falsy #63

Closed
mbest opened this issue Apr 28, 2018 · 1 comment
Closed

arrayFirst returns undefined if found value is falsy #63

mbest opened this issue Apr 28, 2018 · 1 comment

Comments

@mbest
Copy link
Member

mbest commented Apr 28, 2018

For example, "", 0, null.

tko/packages/tko.utils/src/array.js

Line 22 in 4f302f5

.find(predicate, predicateOwner) || undefined

@brianmhunt
Copy link
Member

Thanks @mbest ; that seems a. clearly the wrong behaviour here, and b. like something I would have done in response to some tests failing. Will look into it.

brianmhunt added a commit that referenced this issue May 14, 2018
@brianmhunt
Fix arrayFirst returning undefined when found element is falsy
724e97e 
Fixes #63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brianmhunt @mbest